This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Housekeeping: merge release branch 1.25.x into master
Signed-off-by: Paulo Gomes <[email protected]>
Release chart 1.13.2
We are removing all of the telemetry code as it is not needed, and being on by default it may be contrary to CNCF policies around telemetry. * remove check function With no telemetry, there's no need for these function implementations or this syscall in this package anymore. We need to preserve the cadence of checkpoint.go to avoid disturbing any thing that would constitute a breaking change, but basically all of the underlying behavior of check can go away, since every Flux v1 version is out of date every time, we don't need any remote service or lookup to tell if an update is needed. (It's always needed) Users should follow the link to upgrade (eg. the migration guide) Signed-off-by: Kingdon Barrett <[email protected]> Update pkg/checkpoint/checkpoint.go Signed-off-by: Kingdon Barrett <[email protected]> Co-authored-by: Stefan Prodan <[email protected]>
Remove telemetry
* to NOTES.txt * to fluxctl install Let new users know as soon as they start using Flux that this version is going to be deprecated. Signed-off-by: Kingdon Barrett <[email protected]>
Add deprecation warnings to Helm Chart and fluxctl
Signed-off-by: Kingdon Barrett <[email protected]>
Signed-off-by: Kingdon Barrett <[email protected]>
Merged
pjbgf
reviewed
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - pending the dependencies PR merge.
* no need to upgrade Flux to yaml.v3 The dependencies which use yaml.v3 pinned a specific unreleased version that was not secure, so we should replace it. (There's no CVE reported against v2.4.0, the version that Flux itself uses internally.) Co-authored-by: Paulo Gomes <[email protected]> Signed-off-by: Kingdon Barrett <[email protected]>
Update dependencies
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be amended to include:
Once that one merges first, I will merge
master
torelease/1.25.4
and this release should be ready to go.